Skip to content

[SPARK-51139][ML][CONNECT] Refine error class MLAttributeNotAllowedException #49860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-51139][ML][CONNECT] Refine error class MLAttributeNotAllowedException #49860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/utils/src/main/resources/error/error-conditions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@
"subClass" : {
"ATTRIBUTE_NOT_ALLOWED" : {
"message" : [
"<attribute> is not allowed to be accessed."
"<attribute> in <className> is not allowed to be accessed."
]
},
"UNSUPPORTED_EXCEPTION" : {
Expand Down
4 changes: 2 additions & 2 deletions sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLException.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ private[spark] case class MlUnsupportedException(message: String)
messageParameters = Map("message" -> message),
cause = null)

private[spark] case class MLAttributeNotAllowedException(attribute: String)
private[spark] case class MLAttributeNotAllowedException(className: String, attribute: String)
extends SparkException(
errorClass = "CONNECT_ML.ATTRIBUTE_NOT_ALLOWED",
messageParameters = Map("attribute" -> attribute),
messageParameters = Map("className" -> className, "attribute" -> attribute),
cause = null)
2 changes: 1 addition & 1 deletion sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ private[ml] object MLUtils {
cls.isInstance(obj) && methods.contains(method)
}
if (!valid) {
throw MLAttributeNotAllowedException(method)
throw MLAttributeNotAllowedException(obj.getClass.getName, method)
}
}

Expand Down
5 changes: 4 additions & 1 deletion sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ml/MLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,12 @@ class MLSuite extends MLHelper {
val modelId = trainLogisticRegressionModel(sessionHolder)

val fakeAttributeCmd = fetchCommand(modelId, "notExistingAttribute")
intercept[MLAttributeNotAllowedException] {
val e = intercept[MLAttributeNotAllowedException] {
MLHandler.handleMlCommand(sessionHolder, fakeAttributeCmd)
}
val msg = e.getMessage
assert(msg.contains("notExistingAttribute"))
assert(msg.contains("org.apache.spark.ml.classification.LogisticRegressionModel"))
}

test("Model must be registered into ServiceLoader when loading") {
Expand Down