Skip to content

[SPARK-5186][branch-1.2] Vector.hashCode is not efficient #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-5186][branch-1.2] Vector.hashCode is not efficient #4985

wants to merge 1 commit into from

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Mar 11, 2015

Backport @hhbyyh 's hasCode implementation to branch-1.2. The old implementation causes performance issues with PySpark, which calls hashCode (https://issues.apache.org/jira/browse/SPARK-6288).

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28476 has started for PR 4985 at commit 578214d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28476 has finished for PR 4985 at commit 578214d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 11, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28476/
Test FAILed.

@mengxr mengxr changed the title [SPARK-5186][branch-1.2] Vector.hashCode is not efficient [SPARK-5186, SPARK-5050, SPARK-4797][branch-1.2] Vector.hashCode is not efficient Mar 11, 2015
@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28482 has started for PR 4985 at commit aafab62.

  • This patch merges cleanly.

@mengxr mengxr changed the title [SPARK-5186, SPARK-5050, SPARK-4797][branch-1.2] Vector.hashCode is not efficient [SPARK-5186][branch-1.2] Vector.hashCode is not efficient Mar 11, 2015
@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28483 has started for PR 4985 at commit 155e559.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28483 has finished for PR 4985 at commit 155e559.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28483/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Mar 11, 2015

Test build #28482 has finished for PR 4985 at commit aafab62.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Mar 11, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28482/
Test PASSed.

asfgit pushed a commit that referenced this pull request Mar 12, 2015
@hhbyyh @mengxr
[SPARK-5186][branch-1.2] Vector.hashCode is not efficient
c684e5f 
Backport hhbyyh 's hasCode implementation to branch-1.2. The old implementation causes performance issues with PySpark, which calls hashCode (https://issues.apache.org/jira/browse/SPARK-6288).

Author: Yuhao Yang <[email protected]>

Closes #4985 from mengxr/SPARK-5186-1.2 and squashes the following commits:

155e559 [Yuhao Yang] backport SPARK-5186
@mengxr
Copy link
Contributor Author

mengxr commented Mar 12, 2015

Merged into branch-1.2.

@mengxr mengxr closed this Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mengxr @SparkQA @AmplabJenkins @hhbyyh