[SPARK-51026][CORE][TESTS] Remove the unnecessary test file StagePageSuite.scala
#49721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 29, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. The points look reasonable to me, too. Thank you, @LuciferYang .
Contributor
Author
|
Thank you @dongjoon-hyun |
LuciferYang
changed the title
StagePageSuite.scala.StagePageSuite.scala
LuciferYang
added a commit
that referenced
this pull request
Jan 29, 2025
…eSuite.scala` ### What changes were proposed in this pull request? This pr removes a test file `StagePageSuite.scala` that is no longer needed. ### Why are the changes needed? The current `StagePageSuite.scala` contains one test case and one private method. The reasons for cleaning them up are as follows: 1. The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | #42085. Currently, this test case only creates a `StageData` object and an `AppStatusStore` object, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such as `KVStoreProtobufSerializerSuite`, `AppStatusStoreSuite`, etc. Therefore, this is already an unnecessary test case and can be cleaned up. 2. The private method `renderStagePage` has not been used since SPARK-21809 | #21688, so it can be cleaned up. After cleaning up the above content, `StagePageSuite.scala` becomes an empty file, so it can be completely deleted. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #49721 from LuciferYang/SPARK-51026. Authored-by: yangjie01 <[email protected]> Signed-off-by: yangjie01 <[email protected]> (cherry picked from commit 3badfd2) Signed-off-by: yangjie01 <[email protected]>
Contributor
Author
|
Merged into master and branch-4.0. Thanks @dongjoon-hyun |
zifeif2
pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 14, 2025
…eSuite.scala` ### What changes were proposed in this pull request? This pr removes a test file `StagePageSuite.scala` that is no longer needed. ### Why are the changes needed? The current `StagePageSuite.scala` contains one test case and one private method. The reasons for cleaning them up are as follows: 1. The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | apache#42085. Currently, this test case only creates a `StageData` object and an `AppStatusStore` object, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such as `KVStoreProtobufSerializerSuite`, `AppStatusStoreSuite`, etc. Therefore, this is already an unnecessary test case and can be cleaned up. 2. The private method `renderStagePage` has not been used since SPARK-21809 | apache#21688, so it can be cleaned up. After cleaning up the above content, `StagePageSuite.scala` becomes an empty file, so it can be completely deleted. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#49721 from LuciferYang/SPARK-51026. Authored-by: yangjie01 <[email protected]> Signed-off-by: yangjie01 <[email protected]> (cherry picked from commit fb742ff) Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr removes a test file
StagePageSuite.scalathat is no longer needed.Why are the changes needed?
The current
StagePageSuite.scalacontains one test case and one private method. The reasons for cleaning them up are as follows:The assertion in the test case "ApiHelper.COLUMN_TO_INDEX should match headers of the task table" was cleaned up in SPARK-44490 | [SPARK-44490][WEBUI] Remove unused
TaskPagedTablein StagePage #42085. Currently, this test case only creates aStageDataobject and anAppStatusStoreobject, with no other operations or assertions. Moreover, the creation of these objects is also covered in other test cases, such asKVStoreProtobufSerializerSuite,AppStatusStoreSuite, etc. Therefore, this is already an unnecessary test case and can be cleaned up.The private method
renderStagePagehas not been used since SPARK-21809 | [SPARK-21809] : Change Stage Page to use datatables to support sorting columns and searching #21688, so it can be cleaned up.After cleaning up the above content,
StagePageSuite.scalabecomes an empty file, so it can be completely deleted.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No