Skip to content

[SPARK-5845][Shuffle] Time to cleanup spilled shuffle files not included in shuffle write time #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[SPARK-5845][Shuffle] Time to cleanup spilled shuffle files not included in shuffle write time #4965

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db8647e
Added update for shuffleWriteTime around spilled file cleanup in Exte…
Feb 25, 2015
9434b50
Merge remote-tracking branch 'upstream/master' into SPARK-5845
Mar 10, 2015
b946d08
Fixed error with option
Mar 11, 2015
3e059b0
Switched to using getorelse
Mar 11, 2015
bfabf88
Changed to using a foreach vs. getorelse
Mar 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleWriter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@ private[spark] class SortShuffleWriter[K, V, C](
} finally {
// Clean up our sorter, which may have its own intermediate files
if (sorter != null) {
val startTime = System.nanoTime()
Copy link
Member

@srowen srowen Mar 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @kayousterhout
Just checking, this is meant to be in nanos and not milliseconds?

Copy link
Author

@ilganeli ilganeli Mar 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sean - other usages of writeMetrics.incShuffleWriteTime also use nanoTime(). Please see BlockObjectWriter::callWithTiming() and ExternalSorter::writePartitionedFile.

sorter.stop()
context.taskMetrics.shuffleWriteMetrics.foreach(
_.incShuffleWriteTime(System.nanoTime - startTime))
sorter = null
}
}
Expand Down