[SPARK-50624][SQL] Add TimestampNTZType to ColumnarRow/MutableColumnarRow #49437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cloud-fan could you take a look please? |
nastra
force-pushed
the
SPARK-50624
branch
3 times, most recently
from
a0f04ea to
73db5f7
Compare
nastra
changed the title
cloud-fan
approved these changes
Jan 10, 2025
MaxGekk
reviewed
Jan 10, 2025
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
lgtm except of a minor comment
sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ColumnarRow.java
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Jan 10, 2025
Contributor
|
thanks, merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 13, 2025
…rRow ### What changes were proposed in this pull request? Noticed that this was missing when using this in Iceberg. See additional details in apache/iceberg#11815 (comment) ### Why are the changes needed? To be able to read `TimestampNTZType` when using `ColumnarRow` ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Added some unit tests that failed without the fix ### Was this patch authored or co-authored using generative AI tooling? No Closes #49437 from nastra/SPARK-50624. Authored-by: Eduard Tudenhoefner <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d7545d0) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Noticed that this was missing when using this in Iceberg. See additional details in apache/iceberg#11815 (comment)
Why are the changes needed?
To be able to read
TimestampNTZTypewhen usingColumnarRowDoes this PR introduce any user-facing change?
no
How was this patch tested?
Added some unit tests that failed without the fix
Was this patch authored or co-authored using generative AI tooling?
No