SPARK-6205 [CORE] UISeleniumSuite fails for Hadoop 2.x test with NoClassDefFoundError

[srowen]

Add xml-apis to core test deps to work aroudn UISeleniumSuite classpath issue

[SparkQA]

Test build #28348 has started for PR 4933 at commit ddd4d32.

• This patch merges cleanly.

[SparkQA]

Test build #28348 has finished for PR 4933 at commit ddd4d32.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class BinaryClassificationMetrics(JavaModelWrapper):

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28348/
Test PASSed.

[vanzin]

So selenium depends on this but doesn't declare it?

Also, super minor, but the "scope" here is probably redundant.

[srowen]

It does, but for some reason, the org.w3c class I mentioned doesn't turn up at runtime during the tests. It doesn't happen in a plain vanilla build, but does with the Hadoop 2-style build I ran. The class in question appears to only come from xml-apis.

This looks like the key difference in dependency:tree between the two:

192,193c333
< [INFO] |  |  |  +- xerces:xercesImpl:jar:2.11.0:test
< [INFO] |  |  |  |  \- xml-apis:xml-apis:jar:1.4.01:test
---
> [INFO] |  |  |  +- (xerces:xercesImpl:jar:2.11.0:test - omitted for conflict with 2.9.1)

(Hadoop 2 on the right / >) Looks like something trumps Xerces 2.11 in test scope, with 2.9.1, and that brings in a different xml-apis that doesn't work.

I specified tests in the parent to make sure we don't inadvertently manage non-test deps, and here for clarity.

[vanzin]

Ok, thanks for the maven output, always helps clarify things. :-)

LGTM.