[SPARK-50485][SQL] Unwrap SparkThrowable in (Unchecked)ExecutionException thrown by tableRelationCache #49050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on thrown by tableRelationCache
…on thrown by tableRelationCache
…on thrown by tableRelationCache
MaxGekk
reviewed
Dec 4, 2024
...re/src/test/scala/org/apache/spark/sql/execution/command/v1/AlterTableSetLocationSuite.scala
Outdated
Show resolved
Hide resolved
...re/src/test/scala/org/apache/spark/sql/execution/command/v1/AlterTableSetLocationSuite.scala
Outdated
Show resolved
Hide resolved
…/v1/AlterTableSetLocationSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
…/v1/AlterTableSetLocationSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
MaxGekk
reviewed
Dec 4, 2024
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Outdated
Show resolved
Hide resolved
…tionErrorsSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
…tionErrorsSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
…tionErrorsSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
MaxGekk
approved these changes
Dec 4, 2024
Member
|
+1, LGTM. Merging to master. |
Member
Author
|
Thank you, @MaxGekk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR unwraps SparkThrowable in (Unchecked)ExecutionException thrown by tableRelationCache
Why are the changes needed?
The guava cache library wraps exceptions thrown by
c: Callable[LogicalPlan]as(Unchecked)ExecutionExceptions. This makes our code paths of special handling for SparkThrowable inoperative. For example, this kind of error in spark-sql cli is very lengthy.Does this PR introduce any user-facing change?
Yes, when you visit an invalid plan in the table cache layer, you will get the original spark error instead of getting them under
(Unchecked)ExecutionExceptionsHow was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no