[SPARK-6124] Support jdbc connection properties in OPTIONS part of the query

[vlyubin]

One more thing if this PR is considered to be OK - it might make sense to add extra .jdbc() API's that take Properties to SQLContext.

[AmplabJenkins]

Can one of the admins verify this patch?

[aarondav]

Jenkins, add to whitelist

[SparkQA]

Test build #28202 has started for PR 4859 at commit 5bed5f3.

• This patch merges cleanly.

[SparkQA]

Test build #28202 has finished for PR 4859 at commit 5bed5f3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28202/
Test PASSed.

[aarondav]

We should probably document this behavior somewhere -- I'm not sure if there's a standard place for data sources. If nowhere else, at least add it to the doc of createRelation().

[marmbrus]

We should add this to the programming guide under JDBC.

[marmbrus]

(i.e. http://spark.apache.org/docs/latest/sql-programming-guide.html#jdbc-to-other-databases)

[aarondav]

I think it would also be reasonable to add to the SQLContext#jdbc() methods a parameter for options: Map[String, String] like was done for createExternalTable. This would require confirmation by @marmbrus or @rxin, though.

[SparkQA]

Test build #29012 has started for PR 4859 at commit 9f32724.

• This patch merges cleanly.

[aarondav]

This LGTM, we'll merge this and later add a jdbc() version.

[SparkQA]

Test build #29012 has finished for PR 4859 at commit 9f32724.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29012/
Test PASSed.

[marmbrus]

Why null as the default instead of an empty properties map?

[vlyubin]

No particular reason really, both are fine with DriverManagers' getConnection(). I've switched to empty properties map, I guess it is in fact neater than null.

[marmbrus]

One minor comment otherwise LGTM, provided documentation and a programatic interface are added in a follow-up PR.

[SparkQA]

Test build #29032 has started for PR 4859 at commit 7a8cfda.

• This patch merges cleanly.

[SparkQA]

Test build #29032 has finished for PR 4859 at commit 7a8cfda.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29032/
Test PASSed.

[marmbrus]

Thanks! Merged to master and branch-1.3.