[SPARK-49863][SQL] Fix NormalizeFloatingNumbers to preserve nullability of nested structs #48331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
nikhilsheoran-db
force-pushed
the
SPARK-49863-fix
branch
from
b282bbe to
22dd534
Compare
Contributor
Author
|
cc: @cloud-fan to take a look. |
Contributor
|
thanks, merging to master! |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…ty of nested structs
### What changes were proposed in this pull request?
- Fixes a bug in `NormalizeFloatingNumbers` to respect the `nullable` attribute of nested expressions when normalizing.
### Why are the changes needed?
- Without the fix, there would be a degradation in the nullability of the expression post normalization.
- For example, for an expression like: `namedStruct("struct", namedStruct("double", <DoubleType-field>)) ` with the following data type:
```
StructType(StructField("struct", StructType(StructField("double", DoubleType, true, {})), false, {}))
```
after normalizing we would have ended up with the dataType:
```
StructType(StructField("struct", StructType(StructField("double", DoubleType, true, {})), true, {}))
```
Note, the change in the `nullable` attribute of the "double" StructField from `false` to `true`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Added unit test.
### Was this patch authored or co-authored using generative AI tooling?
No
Closes apache#48331 from nikhilsheoran-db/SPARK-49863-fix.
Authored-by: Nikhil Sheoran <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
NormalizeFloatingNumbersto respect thenullableattribute of nested expressions when normalizing.Why are the changes needed?
namedStruct("struct", namedStruct("double", <DoubleType-field>))with the following data type:after normalizing we would have ended up with the dataType:
Note, the change in the
nullableattribute of the "double" StructField fromfalsetotrue.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No