-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-49713][PYTHON][CONNECT] Make function count_min_sketch accept number arguments
#48157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would need a connect version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! let me add one for Scala client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon it seems we don't have a separate functions.scala for Scala client now, after a lot of refactoring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: , optional in the end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
5164098 to
078792f
Compare
56f5793 to
c08d9d9
Compare
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
thanks @dongjoon-hyun @xinrong-meng and @HyukjinKwon merged to master |
What changes were proposed in this pull request?
1, Make function
count_min_sketchaccept number arguments;2, Make argument
seedoptional;3, fix the type hints of
eps/confidence/seedfromColumnOrNametoColumn, because they require a foldable value and actually do not accept column name:Why are the changes needed?
1, seed is optional in other similar functions;
2, existing type hint is
ColumnOrNamewhich is misleading since column name is not actually supportedDoes this PR introduce any user-facing change?
yes, it support number arguments
How was this patch tested?
updated doctests
Was this patch authored or co-authored using generative AI tooling?
no