[SPARK-49611][SQL][FOLLOW-UP] Fix wrong results of collations() TVF #48152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@panbingkun for reference, this mistake slipped in |
HyukjinKwon
changed the title
panbingkun
reviewed
Sep 19, 2024
| COLLATION_PAD_ATTRIBUTE, | ||
| caseSensitivity == CaseSensitivity.CS, | ||
| accentSensitivity == AccentSensitivity.AS); | ||
| accentSensitivity == AccentSensitivity.AS, |
Contributor
There was a problem hiding this comment.
Oh, OMG, I wrote it upside down.
Sorry, thank you very much for fixing it!
panbingkun
approved these changes
Sep 19, 2024
dbatomic
approved these changes
Sep 19, 2024
MaxGekk
approved these changes
Sep 19, 2024
Member
|
+1, LGTM. Merging to master. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? Fix of accent sensitive and case sensitive column results. ### Why are the changes needed? When initial PR was introduced, ICU collation listing ended up with different order of generating columns so results were wrong. ### Does this PR introduce _any_ user-facing change? No, as spark 4.0 was not released yet. ### How was this patch tested? Existing test in CollationSuite.scala, which was wrong in the first place. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48152 from mihailom-db/tvf-collations-followup. Authored-by: Mihailo Milosevic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? Fix of accent sensitive and case sensitive column results. ### Why are the changes needed? When initial PR was introduced, ICU collation listing ended up with different order of generating columns so results were wrong. ### Does this PR introduce _any_ user-facing change? No, as spark 4.0 was not released yet. ### How was this patch tested? Existing test in CollationSuite.scala, which was wrong in the first place. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48152 from mihailom-db/tvf-collations-followup. Authored-by: Mihailo Milosevic <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix of accent sensitive and case sensitive column results.
Why are the changes needed?
When initial PR was introduced, ICU collation listing ended up with different order of generating columns so results were wrong.
Does this PR introduce any user-facing change?
No, as spark 4.0 was not released yet.
How was this patch tested?
Existing test in CollationSuite.scala, which was wrong in the first place.
Was this patch authored or co-authored using generative AI tooling?
No.