[SPARK-49659][SQL] Add a nice user-facing error for scalar subqueries inside VALUES clause #48118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirg-db
force-pushed
the
vladimirg-db/introduce-user-facing-exception-for-inline-tables-with-scalar-subqueries
branch
from
fd9a01c to
fdb33f8
Compare
vladimirg-db
force-pushed
the
vladimirg-db/introduce-user-facing-exception-for-inline-tables-with-scalar-subqueries
branch
from
fdb33f8 to
c9721d9
Compare
cloud-fan
approved these changes
Sep 16, 2024
MaxGekk
reviewed
Sep 16, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
Outdated
Show resolved
Hide resolved
vladimirg-db
force-pushed
the
vladimirg-db/introduce-user-facing-exception-for-inline-tables-with-scalar-subqueries
branch
2 times, most recently
from
fc604fc to
4546834
Compare
Contributor
Author
|
@dtenedor do you think we also need a |
Member
I think if you provided a query context (and you did that), that's enough. |
MaxGekk
requested changes
Sep 16, 2024
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
Outdated
Show resolved
Hide resolved
vladimirg-db
force-pushed
the
vladimirg-db/introduce-user-facing-exception-for-inline-tables-with-scalar-subqueries
branch
from
4546834 to
fa1ca9e
Compare
Contributor
Author
|
@MaxGekk all done, thanks! |
Member
|
@vladimirg-db Please, update PR's description according to your changes. |
vladimirg-db
force-pushed
the
vladimirg-db/introduce-user-facing-exception-for-inline-tables-with-scalar-subqueries
branch
from
fa1ca9e to
c206bb9
Compare
Member
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a new
SCALAR_SUBQUERY_IN_VALUESerror, since we don't support scalar subqueries in the VALUES clause for now.Why are the changes needed?
To make Spark user experience nicer.
Does this PR introduce any user-facing change?
Yes, the exception type/message will be more descriptive
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No