[SPARK-49369][CONNECT][SQL] Add implicit Column conversions #48020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @EnricoMi |
Contributor
Author
|
Shout-out to @larsk-db and @vkorukanti for this idea! |
HyukjinKwon
reviewed
Sep 8, 2024
| .setCustomField("abc") | ||
| .build() | ||
| simple.select(column(_.setExtension(com.google.protobuf.Any.pack(extension)))) | ||
| simple.select(Column(_.setExtension(com.google.protobuf.Any.pack(extension)))) |
Member
There was a problem hiding this comment.
Why don't we just have column method?
Contributor
Author
There was a problem hiding this comment.
It is more to illustrate that the old way works. You can actually use both.
HyukjinKwon
approved these changes
Sep 8, 2024
Contributor
|
Thanks for the public helper method, will test this once it is in the snapshot. |
Contributor
Author
|
I will update this once #48146 is merged. |
Contributor
Author
|
Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This introduces an implicit conversion for the Column companion object that allows a user/developer to create a Column from a catalyst Expression (for Classic) or a proto Expression (Builder) (for Connect). This mostly recreates they had before we refactored the Column API. This comes at the price of adding the an import.
Why are the changes needed?
Improved upgrade experience for Developers and User who create their own Column's from expressions.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
I added it to a couple of places in the code and it works.
Was this patch authored or co-authored using generative AI tooling?
No.