Skip to content

[SPARK-44239][SQL][FOLLOWUP] Do not disable vector memory optimization when hugeVectorThreshold=0 to align its document #47988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-44239][SQL][FOLLOWUP] Do not disable vector memory optimization when hugeVectorThreshold=0 to align its document #47988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public void reset() {
numNulls = 0;
}

if (hugeVectorThreshold > 0 && capacity > hugeVectorThreshold) {
Copy link
Contributor

@cloud-fan cloud-fan Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= 0 means we treat all vectors as huge vectors?

Copy link
Contributor Author

@wankunde wankunde Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes， but = 0 is not recommended, just keep code and documentation consistent

Copy link
Contributor

@cloud-fan cloud-fan Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then shall we update the doc instead?

Copy link
Member

@yaooqinn yaooqinn Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the doc will result in code part change as other places test if hugeVectorThreshold < 0

Copy link
Contributor

@cloud-fan cloud-fan Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see

if (hugeVectorThreshold > -1 && capacity > hugeVectorThreshold) {
capacity = defaultCapacity;
releaseMemory();
reserveInternal(capacity);
Expand Down