Skip to content

SPARK-4579 [WEBUI] Scheduling Delay appears negative #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-4579 [WEBUI] Scheduling Delay appears negative #4796

wants to merge 1 commit into from

Conversation

@srowen
Copy link
Member

@srowen srowen commented Feb 26, 2015

Ensure scheduler delay handles unfinished task case, and ensure delay is never negative even due to rounding

@SparkQA
Copy link

SparkQA commented Feb 26, 2015

Test build #28024 has started for PR 4796 at commit ad6713c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 26, 2015

Test build #28024 has finished for PR 4796 at commit ad6713c.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 26, 2015

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28024/
Test FAILed.

@kayousterhout
Copy link
Contributor

kayousterhout commented Feb 26, 2015

LGTM Thanks @srowen !

@pwendell
Copy link
Contributor

pwendell commented Feb 26, 2015

Jenkins, test this please.

@pwendell
Copy link
Contributor

pwendell commented Feb 26, 2015

Yeah this would be great to pull into an RC... a very confusing presentation in the UI right now!

@SparkQA
Copy link

SparkQA commented Feb 26, 2015

Test build #28027 has started for PR 4796 at commit ad6713c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 27, 2015

Test build #28027 has finished for PR 4796 at commit ad6713c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 27, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28027/
Test PASSed.

@andrewor14
Copy link
Contributor

andrewor14 commented Feb 27, 2015

Ok I've pulled this into master 1.3 and 1.2 thanks.

asfgit pushed a commit that referenced this pull request Feb 27, 2015
@srowen
SPARK-4579 [WEBUI] Scheduling Delay appears negative
d0bf938 
Ensure scheduler delay handles unfinished task case, and ensure delay is never negative even due to rounding

Author: Sean Owen <[email protected]>

Closes #4796 from srowen/SPARK-4579 and squashes the following commits:

ad6713c [Sean Owen] Ensure scheduler delay handles unfinished task case, and ensure delay is never negative even due to rounding
@asfgit asfgit closed this in fbc4694 Feb 27, 2015
asfgit pushed a commit that referenced this pull request Feb 27, 2015
@srowen
SPARK-4579 [WEBUI] Scheduling Delay appears negative
b83a93e 
Ensure scheduler delay handles unfinished task case, and ensure delay is never negative even due to rounding

Author: Sean Owen <[email protected]>

Closes #4796 from srowen/SPARK-4579 and squashes the following commits:

ad6713c [Sean Owen] Ensure scheduler delay handles unfinished task case, and ensure delay is never negative even due to rounding

(cherry picked from commit fbc4694)
Signed-off-by: Andrew Or <[email protected]>
@srowen srowen deleted the SPARK-4579 branch February 27, 2015 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@srowen @SparkQA @AmplabJenkins @kayousterhout @pwendell @andrewor14