[SPARK-49480][CORE] Fix NullPointerException from SparkThrowableHelper.isInternalError
#47946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.isInternalError`
The SparkThrowableHelper.isInternalError method doesn't handle null input, and it could lead to NullPointerException.
Example stacktrace from our environment with Spark 3.5.1:
```
Caused by: java.lang.NullPointerException: Cannot invoke "String.startsWith(String)" because "errorClass" is null
at org.apache.spark.SparkThrowableHelper$.isInternalError(SparkThrowableHelper.scala:64)
at org.apache.spark.SparkThrowableHelper.isInternalError(SparkThrowableHelper.scala)
at org.apache.spark.SparkThrowable.isInternalError(SparkThrowable.java:50)
at org.apache.spark.SparkException.isInternalError(SparkException.scala:27)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:688)
at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:772)
... 30 more
```
Contributor
Author
|
Kindly ping @bozhang2820 @cloud-fan. Please take a look, thanks! |
MaxGekk
reviewed
Sep 1, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
After your changes, this check st.getErrorClass != null is redundant.
@jshmchenxi Could your remove it, please.
Contributor
Author
@MaxGekk Thanks for review! Removing it will change the condition from false to true when Before: |
Member
I see, it checks not only internal but not internal AND defined error class. Thank you for checking. |
cloud-fan
approved these changes
Sep 2, 2024
Contributor
|
thanks, merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Sep 2, 2024
…er.isInternalError` ### What changes were proposed in this pull request? Handle null input for `SparkThrowableHelper.isInternalError` method. ### Why are the changes needed? The `SparkThrowableHelper.isInternalError` method doesn't handle null input, and it could lead to NullPointerException. It happens when a `SparkException` without `errorClass` is invoked `isInternalError`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add 2 assertions to current test cases to cover this issue. ### Was this patch authored or co-authored using generative AI tooling? No Closes #47946 from jshmchenxi/SPARK-49480/null-pointer-is-internal-error. Authored-by: Xi Chen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit cef3c86) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan Thank you! |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…er.isInternalError` (apache#554) ### What changes were proposed in this pull request? Handle null input for `SparkThrowableHelper.isInternalError` method. ### Why are the changes needed? The `SparkThrowableHelper.isInternalError` method doesn't handle null input, and it could lead to NullPointerException. It happens when a `SparkException` without `errorClass` is invoked `isInternalError`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add 2 assertions to current test cases to cover this issue. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47946 from jshmchenxi/SPARK-49480/null-pointer-is-internal-error. Authored-by: Xi Chen <[email protected]> (cherry picked from commit cef3c86) Signed-off-by: Wenchen Fan <[email protected]> Co-authored-by: Xi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Handle null input for
SparkThrowableHelper.isInternalErrormethod.Why are the changes needed?
The
SparkThrowableHelper.isInternalErrormethod doesn't handle null input, and it could lead to NullPointerException. It happens when aSparkExceptionwithouterrorClassis invokedisInternalError.Does this PR introduce any user-facing change?
No
How was this patch tested?
Add 2 assertions to current test cases to cover this issue.
Was this patch authored or co-authored using generative AI tooling?
No