[SPARK-49392][SQL] Catch errors when failing to write to external data source #47873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...re/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
Outdated
Show resolved
Hide resolved
MaxGekk
reviewed
Aug 27, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
...re/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
Show resolved
Hide resolved
MaxGekk
reviewed
Sep 1, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
The createRelation() method is called from 2 places at the moment. Shall we catch and provide similar errors at writeAndRead() (or in its caller).
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Outdated
Show resolved
Hide resolved
MaxGekk
requested changes
Sep 1, 2024
...re/src/main/scala/org/apache/spark/sql/execution/datasources/SaveIntoDataSourceCommand.scala
Show resolved
Hide resolved
MaxGekk
reviewed
Sep 11, 2024
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala
Show resolved
Hide resolved
MaxGekk
requested changes
Sep 11, 2024
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
requested changes
Sep 13, 2024
sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Sep 13, 2024
Member
|
+1, LGTM. Merging to master. |
MaxGekk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Catch various exceptions thrown by the data source API, when failing to write to a data source, and rethrow
externalDataSourceExceptionto provide a more friendly error message for the user.Why are the changes needed?
To catch non-fatal exceptions when failing to save the results of a query into an external data source (for example:
com.crealytics.spark.excel).Does this PR introduce any user-facing change?
Yes, error messages when failing to write to an external data source should now be more user-friendly.
How was this patch tested?
New test in
ExplainSuite.Was this patch authored or co-authored using generative AI tooling?
No.