[SPARK-49373][PROTOBUF][TESTS] Fix ProtobufFunctionsSuite to be environment-independent
#47859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
viirya
changed the title
dongjoon-hyun
changed the title
ProtobufFunctionsSuite test case should not be environment-dependent
dongjoon-hyun
approved these changes
Aug 23, 2024
Member
There was a problem hiding this comment.
+1, LGTM. I also verified locally. Thank you, @viirya .
dongjoon-hyun
changed the title
ProtobufFunctionsSuite test case should not be environment-dependentProtobufFunctionsSuite test case to be environment-independent
dongjoon-hyun
changed the title
ProtobufFunctionsSuite test case to be environment-independentProtobufFunctionsSuite to be environment-independent
Member
|
This only updates Let me merge this. |
dongjoon-hyun
changed the title
ProtobufFunctionsSuite to be environment-independentProtobufFunctionsSuite to be environment-independent
Member
|
Merged to master. |
Member
Author
|
Thank you @dongjoon-hyun |
Member
|
Thanks LGTM |
Member
Author
|
Thank you @HyukjinKwon |
Contributor
|
Late LGTM. Thanks for addressing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch modifies
ProtobufFunctionsSuite's test caseSPARK-49121: from_protobuf and to_protobuf SQL functionsto check the stop index depending on the file path length.Why are the changes needed?
During debugging CI failure in #47843, we found that
ProtobufFunctionsSuite's test caseSPARK-49121: from_protobuf and to_protobuf SQL functionsis environment-dependent.In the test, it checks the start and stop indices of SQL text fragment but the fragment length depends on the repo name of the author of a PR.
Does this PR introduce any user-facing change?
No, test only.
How was this patch tested?
Unit test
Was this patch authored or co-authored using generative AI tooling?
No