[SPARK-49274][CONNECT] Support java serialization based encoders #47806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
reviewed
Aug 20, 2024
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Encoders.scala
Outdated
Show resolved
Hide resolved
allisonwang-db
approved these changes
Aug 20, 2024
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds Encoders.javaSerialization to connect.
It does this by creating an encoder that does not really encode data, but that transforms into something that can be encoded. This is also useful for situations in which we want to define custom serialization logic.
This PR is also a stepping stone for adding Kryo based serialization.
Why are the changes needed?
This change increases parity between the connect and classic scala interfaces.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added tests for both Arrow and Expression encoders.
Was this patch authored or co-authored using generative AI tooling?
No.