[SPARK-49232][INFRA][TESTS] Remove 3.4.2 from SKIP_SPARK_RELEASE_VERSIONS
#47748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
LuciferYang
reviewed
Aug 14, 2024
| .filterNot(_.contains("preview")) | ||
| .map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) | ||
| .filter(_ < org.apache.spark.SPARK_VERSION) | ||
| .filterNot(skipReleaseVersions.contains).toImmutableArraySeq |
Contributor
There was a problem hiding this comment.
Maybe we can keep this function. I am not sure if there will be similar needs in the future that allow us to reuse it again.
Contributor
There was a problem hiding this comment.
We should update pr title and pr description to match the change
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for revision according to @LuciferYang 's comment.
Could you revise the PR title and description as suggested, @panbingkun ?
panbingkun
changed the title
SKIP_SPARK_RELEASE_VERSIONS3.4.2 from SKIP_SPARK_RELEASE_VERSIONS
LuciferYang
approved these changes
Aug 14, 2024
Contributor
Author
Oh, I'm sorry, I miss to synchronize this update (Jira's title has also been updated). |
dongjoon-hyun
approved these changes
Aug 14, 2024
Member
|
Merged to master~ |
IvanK-db
pushed a commit
to IvanK-db/spark
that referenced
this pull request
Sep 20, 2024
…ERSIONS` ### What changes were proposed in this pull request? The pr aims to remove `3.4.2` from `SKIP_SPARK_RELEASE_VERSIONS(build_maven.yml)`. ### Why are the changes needed? - Why was `SKIP_SPARK_RELEASE_VERSIONS` introduced? See here: https://issues.apache.org/jira/browse/SPARK-46400 - [SPARK-46400](apache#45017) has already merged into Spark `3.4.3`, and the corresponding issue no longer exists for Spark `3.4.3+` - The following location only includes `the version` we have `fixed` for this issue https://dist.apache.org/repos/dist/release/spark/ <img width="433" alt="image" src="https://github.com/user-attachments/assets/bfdf8bca-b972-490a-bc19-cb95eb83a352"> ### Does this PR introduce _any_ user-facing change? No, only for GA's tests. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47748 from panbingkun/SPARK-49232. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
…ERSIONS` ### What changes were proposed in this pull request? The pr aims to remove `3.4.2` from `SKIP_SPARK_RELEASE_VERSIONS(build_maven.yml)`. ### Why are the changes needed? - Why was `SKIP_SPARK_RELEASE_VERSIONS` introduced? See here: https://issues.apache.org/jira/browse/SPARK-46400 - [SPARK-46400](apache#45017) has already merged into Spark `3.4.3`, and the corresponding issue no longer exists for Spark `3.4.3+` - The following location only includes `the version` we have `fixed` for this issue https://dist.apache.org/repos/dist/release/spark/ <img width="433" alt="image" src="https://github.com/user-attachments/assets/bfdf8bca-b972-490a-bc19-cb95eb83a352"> ### Does this PR introduce _any_ user-facing change? No, only for GA's tests. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47748 from panbingkun/SPARK-49232. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…ERSIONS` ### What changes were proposed in this pull request? The pr aims to remove `3.4.2` from `SKIP_SPARK_RELEASE_VERSIONS(build_maven.yml)`. ### Why are the changes needed? - Why was `SKIP_SPARK_RELEASE_VERSIONS` introduced? See here: https://issues.apache.org/jira/browse/SPARK-46400 - [SPARK-46400](apache#45017) has already merged into Spark `3.4.3`, and the corresponding issue no longer exists for Spark `3.4.3+` - The following location only includes `the version` we have `fixed` for this issue https://dist.apache.org/repos/dist/release/spark/ <img width="433" alt="image" src="https://github.com/user-attachments/assets/bfdf8bca-b972-490a-bc19-cb95eb83a352"> ### Does this PR introduce _any_ user-facing change? No, only for GA's tests. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47748 from panbingkun/SPARK-49232. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to remove
3.4.2fromSKIP_SPARK_RELEASE_VERSIONS(build_maven.yml).Why are the changes needed?
Why was
SKIP_SPARK_RELEASE_VERSIONSintroduced? See here: https://issues.apache.org/jira/browse/SPARK-46400SPARK-46400 has already merged into Spark
3.4.3, and the corresponding issue no longer exists for Spark3.4.3+The following location only includes
the versionwe havefixedfor this issuehttps://dist.apache.org/repos/dist/release/spark/
Does this PR introduce any user-facing change?
No, only for GA's tests.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.