[SPARK-49120][BUILD] Bump Gson 2.11.0 #47627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
yaooqinn
reviewed
Aug 6, 2024
| derbyshared/10.16.1.1//derbyshared-10.16.1.1.jar | ||
| derbytools/10.16.1.1//derbytools-10.16.1.1.jar | ||
| dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar | ||
| error_prone_annotations/2.18.0//error_prone_annotations-2.18.0.jar |
Member
There was a problem hiding this comment.
please include this in the LICENSE-binary
LuciferYang
reviewed
Aug 6, 2024
| derbyshared/10.16.1.1//derbyshared-10.16.1.1.jar | ||
| derbytools/10.16.1.1//derbytools-10.16.1.1.jar | ||
| dropwizard-metrics-hadoop-metrics2-reporter/0.1.2//dropwizard-metrics-hadoop-metrics2-reporter-0.1.2.jar | ||
| error_prone_annotations/2.18.0//error_prone_annotations-2.18.0.jar |
Contributor
There was a problem hiding this comment.
Do we have to add this dependency?
Member
Author
There was a problem hiding this comment.
short answer, no, but Gson changed it to compile scope in google/gson#2346
I'm okay with either include or exclude it from Spark classpath
yaooqinn
approved these changes
Aug 6, 2024
LuciferYang
approved these changes
Aug 6, 2024
Member
|
Thank you @pan3793 @LuciferYang Merged to master |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
### What changes were proposed in this pull request? Currently, Spark pulls Gson 2.2.4 from `hive-exec`, which is pretty old and [vulnerable](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-25647), this PR proposes to upgrade it to the latest version 2.11.0. <img width="697" alt="image" src="https://github.com/user-attachments/assets/f101ab3f-875c-4cc3-9692-48394c9ada3e"> ### Why are the changes needed? For security. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47627 from pan3793/SPARK-49120. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit 9fb9cff) Co-authored-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark pulls Gson 2.2.4 from
hive-exec, which is pretty old and vulnerable, this PR proposes to upgrade it to the latest version 2.11.0.Why are the changes needed?
For security.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
GHA.
Was this patch authored or co-authored using generative AI tooling?
No.