[SPARK-49104][CORE][DOCS] Document JWSFilter usage in Spark UI and REST API and rename parameter to secretKey
#47596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…REST API and rename parameter to `secretKey`
dongjoon-hyun
commented
Aug 4, 2024
| <tr> | ||
| <td><code>spark.redaction.regex</code></td> | ||
| <td>(?i)secret|password|token|access[.]key</td> | ||
| <td>(?i)secret|password|token|access[.]?key</td> |
dongjoon-hyun
commented
Aug 4, 2024
| */ | ||
| override def init(config: FilterConfig): Unit = { | ||
| key = Keys.hmacShaKeyFor(Decoders.BASE64URL.decode(config.getInitParameter("key"))); | ||
| key = Keys.hmacShaKeyFor(Decoders.BASE64URL.decode(config.getInitParameter("secretKey"))); |
Member
Author
There was a problem hiding this comment.
Currently, key can be exposed if spark.ui.filters configuration is removed mistakenly.
Member
There was a problem hiding this comment.
secretKey will be redact by Spark, right?
Member
There was a problem hiding this comment.
As you make the change #47596 (comment), do we still need to change this param to secretKey?
Member
Author
|
Could you review this, @viirya ? |
Member
Author
|
Could you review this PR, @yaooqinn ? |
viirya
approved these changes
Aug 4, 2024
HyukjinKwon
approved these changes
Aug 4, 2024
Member
|
Merged to master. |
Member
Author
|
Thank you, @viirya and @HyukjinKwon . To @viirya , yes. We need to rename
|
Member
|
Late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims the following.
JWSFilterand its usage inSpark UIandREST APISpark UIsection ofConfigurationpageSpark SecuritypageSpark StandalonepagekeytosecretKeyto redact it in Spark Driver UI and Spark Master UI.Why are the changes needed?
To apply recent new security features
JWSFilter#47575spark.master.rest.filters#47595Does this PR introduce any user-facing change?
No because this is a new feature of Apache Spark 4.0.0.
How was this patch tested?
Pass the CIs and manual review.
spark-standalone.htmlsecurity.htmlconfiguration.htmlWas this patch authored or co-authored using generative AI tooling?
No.