[SPARK-48763][CONNECT][BUILD][FOLLOW-UP] Move Spark Connect common/server into sql directory #47579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
SQL
STRUCTURED STREAMING
WEB UI
BUILD
DOCS
INFRA
PYTHON
CONNECT
labels
Member
Author
|
cc @hvanhovell |
dongjoon-hyun
approved these changes
Aug 2, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Although this is a massive change, +1 for the direction for Apache Spark 4.0.0 . Thank you, @HyukjinKwon .
Member
Author
|
Thank you!!! |
Member
Author
|
Merged to master. |
HyukjinKwon
added a commit
that referenced
this pull request
Aug 5, 2024
…tionTestSuite ### What changes were proposed in this pull request? This PR is a followup of #47579 that updates the Spark Connect location in the test `PlanGenerationTestSuite`. ### Why are the changes needed? Just for completeness. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran it via: ```bash SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "connect-client-jvm/testOnly org.apache.spark.sql.PlanGenerationTestSuite" ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47605 from HyukjinKwon/SPARK-48763-followup2. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #47157 that moves
connectintosql/connect.Why are the changes needed?
The reasons are as follow:
connectas a standalone top level ([SPARK-48763][CONNECT][BUILD] Move connect server and common to builtin module #47157 (comment)).sqljust like Hive thrift server.spark.sqlconfigurations, e.g.,spark.sql.connect.serverStacktrace.enabledDoes this PR introduce any user-facing change?
No.
How was this patch tested?
CI in this PR should verify it.
Was this patch authored or co-authored using generative AI tooling?
No.