[SPARK-49060][CONNECT] Clean up Mima rules for SQL-Connect binary compatibility checks #47487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR modifies some Mima rules which are used for checking the binary compatibility between
sqlandconnectmodules. Major changes include:private[sql]constructors - there's a wildcard rule which filters out all of them.Current output:
I manually audited all rules defined in the list.
One issue I found is that all APIs in
Datasetare not being checked at all, likely due to having aprivate[sql]companion object inspark-core. Changing the object's visibility fromprivate[sql]topublicwill resolve this issue. The exact reason is unknown and is to be investigated.Why are the changes needed?
Need to make sure Mima is really working.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Not needed.
Was this patch authored or co-authored using generative AI tooling?
No.