Skip to content

[SPARK-48544][SQL] Reduce memory pressure of empty TreeNode BitSets #46919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-48544][SQL] Reduce memory pressure of empty TreeNode BitSets #46919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb2ec5c
Make ineffectiveRules lazy
n-young-db Jun 7, 2024
5d01eb5
Update sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/tree…
n-young-db Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,14 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
* ineffective for subsequent apply calls on this tree because query plan structures are
* immutable.
*/
private val ineffectiveRules: BitSet = new BitSet(RuleIdCollection.NumRules)
private[this] var _ineffectiveRules: BitSet = null
private def ineffectiveRules: BitSet = {
if (_ineffectiveRules eq null) {
_ineffectiveRules = new BitSet(RuleIdCollection.NumRules)
}
_ineffectiveRules
}
private def isIneffectiveRulesEmpty = _ineffectiveRules eq null

/**
* @return a sequence of tree pattern enums in a TreeNode T. It does not include propagated
Expand Down Expand Up @@ -149,7 +156,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
* UnknownId, it returns false.
*/
protected def isRuleIneffective(ruleId : RuleId): Boolean = {
if (ruleId eq UnknownRuleId) {
if (isIneffectiveRulesEmpty || (ruleId eq UnknownRuleId)) {
return false
}
ineffectiveRules.get(ruleId.id)
Expand Down