[SPARK-48564][PYTHON][CONNECT] Propagate cached schema in set operations #46915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
set_op_schema
branch
from
4fa48e8 to
25d6abb
Compare
HyukjinKwon
reviewed
Jun 8, 2024
| # when the cached schemas are exactly the same | ||
| if self._cached_schema is not None and self._cached_schema == other._cached_schema: | ||
| return self.schema | ||
| return None |
Member
There was a problem hiding this comment.
you can just remove this too
HyukjinKwon
approved these changes
Jun 8, 2024
zhengruifeng
force-pushed
the
set_op_schema
branch
from
25d6abb to
56d1917
Compare
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Propagate cached schema in set operations
Why are the changes needed?
to avoid extra RPC to get the schema of result data frame
Does this PR introduce any user-facing change?
No
How was this patch tested?
added tests
Was this patch authored or co-authored using generative AI tooling?
No