Skip to content

[WIP][SPARK-48172][SQL] Fix escaping issues in JDBCDialects #46803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[WIP][SPARK-48172][SQL] Fix escaping issues in JDBCDialects #46803

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33e27a8
Fix OracleIntegrationSuit
mihailom-db May 30, 2024
7bb6e44
Fix problem of escaping in test
mihailom-db May 30, 2024
9ec32c7
Rework insertion
mihailom-db May 30, 2024
54ea0a7
Update DockerJDBCIntegrationV2Suite.scala
mihailom-db May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions ...tion-tests/src/test/scala/org/apache/spark/sql/jdbc/v2/DockerJDBCIntegrationV2Suite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,24 @@ abstract class DockerJDBCIntegrationV2Suite extends DockerJDBCIntegrationSuite {
connection.prepareStatement("INSERT INTO employee VALUES (6, 'jen', 12000, 1200)")
.executeUpdate()

connection.prepareStatement(
s"""
|INSERT INTO pattern_testing_table VALUES
|('special_character_quote''_present'),
|('special_character_quote_not_present'),
|('special_character_percent%_present'),
|('special_character_percent_not_present'),
|('special_character_underscore_present'),
|('special_character_underscorenot_present')
""".stripMargin).executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_quote''_present')")
.executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_quote_not_present')")
.executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_percent%_present')")
.executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_percent_not_present')")
.executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_underscore_present')")
.executeUpdate()
connection.prepareStatement("INSERT INTO pattern_testing_table "
+ "VALUES ('special_character_underscorenot_present')")
.executeUpdate()
}

def tablePreparation(connection: Connection): Unit
Expand Down