Skip to content

Conversation

@liancheng
Copy link
Contributor

Although we've migrated to the DataFrame API, lots of code still uses rdd or srdd as local variable names. This PR tries to address these naming inconsistencies and some other minor DataFrame related style issues.

Review on Reviewable

@liancheng
Copy link
Contributor Author

cc @rxin

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27674 has started for PR 4670 at commit 3e14448.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 18, 2015

Test build #27674 has finished for PR 4670 at commit 3e14448.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27674/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Feb 18, 2015

Thanks for doing this.

asfgit pushed a commit that referenced this pull request Feb 18, 2015
Although we've migrated to the DataFrame API, lots of code still uses `rdd` or `srdd` as local variable names. This PR tries to address these naming inconsistencies and some other minor DataFrame related style issues.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4670)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #4670 from liancheng/df-cleanup and squashes the following commits:

3e14448 [Cheng Lian] Cleans up DataFrame variable names and toDF() calls

(cherry picked from commit 61ab085)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 61ab085 Feb 18, 2015
@liancheng liancheng deleted the df-cleanup branch February 18, 2015 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants