Skip to content

SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2 #4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2 #4653

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
843eafb
SPARK-5548: Fix for AkkaUtilsSuite failure - attempt 2
jacek-lewandowski Feb 17, 2015
0e199b6
SPARK-5548: applied reviewer's comments
jacek-lewandowski Feb 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/src/test/scala/org/apache/spark/util/AkkaUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package org.apache.spark.util
import java.util.concurrent.TimeoutException

import scala.concurrent.Await
import scala.util.{Failure, Try}

import akka.actor._

Expand Down Expand Up @@ -370,8 +371,12 @@ class AkkaUtilsSuite extends FunSuite with LocalSparkContext with ResetSystemPro
val selection = slaveSystem.actorSelection(
AkkaUtils.address(AkkaUtils.protocol(slaveSystem), "spark", "localhost", boundPort, "MapOutputTracker"))
val timeout = AkkaUtils.lookupTimeout(conf)
intercept[TimeoutException] {
slaveTracker.trackerActor = Await.result(selection.resolveOne(timeout * 2), timeout)
val result = Try(Await.result(selection.resolveOne(timeout * 2), timeout))

result match {
case Failure(ex: ActorNotFound) =>
case Failure(ex: TimeoutException) =>
case r => fail(s"$r is neither Failure(ActorNotFound) nor Failure(TimeoutException)")
}
Copy link
Contributor

@andrewor14 andrewor14 Feb 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will create a lot of warnings complaining that the match is not exhaustive. I thin you'll need to add a case _ => fail(...) to fix this


actorSystem.shutdown()
Expand Down