[SPARK-48226][BUILD] Add spark-ganglia-lgpl to lint-java & spark-ganglia-lgpl and jvm-profiler to sbt-checkstyle
#46501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` and `jvm-profiler` to `sbt-checkstyle`
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you. Could you file a JIRA issue, @panbingkun ? 😄
panbingkun
changed the title
spark-ganglia-lgpl to lint-java & spark-ganglia-lgpl and jvm-profiler to sbt-checkstylespark-ganglia-lgpl to lint-java & spark-ganglia-lgpl and jvm-profiler to sbt-checkstyle
Contributor
Author
Done. |
dongjoon-hyun
approved these changes
May 9, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @panbingkun .
Merged to master.
Contributor
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to add
spark-ganglia-lgpltolint-javaspark-ganglia-lgplandjvm-profilertosbt-checkstyleWhy are the changes needed?
1.Because the module
spark-ganglia-lgplhasjavacode2.Because the module
spark-ganglia-lgpl&jvm-profilerhasscalacode3.Although these module codes currently comply with the specification, in order to avoid problems like #46376, they will occur again in future modifications.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.