Skip to content

[SPARK-48081][SQL][3.5] Fix ClassCastException in NTile.checkInputDataTypes() when argument is non-foldable or of wrong type #46336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-48081][SQL][3.5] Fix ClassCastException in NTile.checkInputDataTypes() when argument is non-foldable or of wrong type #46336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df1d61
[SPARK-48081] Fix ClassCastException in NTile.checkInputDataTypes() w…
JoshRosen May 2, 2024
fa2f353
test expectation updates
JoshRosen May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindow
// for each partition.
override def checkInputDataTypes(): TypeCheckResult = {
if (!buckets.foldable) {
DataTypeMismatch(
return DataTypeMismatch(
errorSubClass = "NON_FOLDABLE_INPUT",
messageParameters = Map(
"inputName" -> "buckets",
Expand All @@ -861,7 +861,7 @@ case class NTile(buckets: Expression) extends RowNumberLike with SizeBasedWindow
}

if (buckets.dataType != IntegerType) {
DataTypeMismatch(
return DataTypeMismatch(
errorSubClass = "UNEXPECTED_INPUT_TYPE",
messageParameters = Map(
"paramIndex" -> "1",
Expand Down
34 changes: 34 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,40 @@ class AnalysisErrorSuite extends AnalysisTest {
"inputType" -> "\"BOOLEAN\"",
"requiredType" -> "\"INT\""))

errorClassTest(
"the buckets of ntile window function is not foldable",
testRelation2.select(
WindowExpression(
NTile(Literal(99.9f)),
WindowSpecDefinition(
UnresolvedAttribute("a") :: Nil,
SortOrder(UnresolvedAttribute("b"), Ascending) :: Nil,
UnspecifiedFrame)).as("window")),
errorClass = "DATATYPE_MISMATCH.UNEXPECTED_INPUT_TYPE",
messageParameters = Map(
"sqlExpr" -> "\"ntile(99.9)\"",
"paramIndex" -> "1",
"inputSql" -> "\"99.9\"",
"inputType" -> "\"FLOAT\"",
"requiredType" -> "\"INT\""))


errorClassTest(
"the buckets of ntile window function is not int literal",
testRelation2.select(
WindowExpression(
NTile(AttributeReference("b", IntegerType)()),
WindowSpecDefinition(
UnresolvedAttribute("a") :: Nil,
SortOrder(UnresolvedAttribute("b"), Ascending) :: Nil,
UnspecifiedFrame)).as("window")),
errorClass = "DATATYPE_MISMATCH.NON_FOLDABLE_INPUT",
messageParameters = Map(
"sqlExpr" -> "\"ntile(b)\"",
"inputName" -> "buckets",
"inputExpr" -> "\"b\"",
"inputType" -> "\"INT\""))

errorClassTest(
"unresolved attributes",
testRelation.select($"abcd"),
Expand Down