[SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output - use === instead of sameElements for Arrays
#46318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
Outdated
Show resolved
Hide resolved
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Given the scope, this is a follow-up of SPARK-47939 instead of a new JIRA.
Could you find more instances like this in SQLQuerySuite? If you can fix more places, we can keep the AS-IS PR title and JIRA ID.
Contributor
Author
|
Yes, @dongjoon-hyun, my intent was to add a small improvement after the SPARK-47939, which was resolved by my PR recently. However you are right - I've added couple of similar improvements to this PR. Thank you for the advice. |
vladimirg-db
changed the title
=== instead of sameElements for Arrays
dongjoon-hyun
approved these changes
May 2, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @vladimirg-db .
Merged to master.
vladimirg-db
deleted the
vladimirg-db/improve-test-output-for-sql-query-suite
branch
JacobZheng0927
pushed a commit
to JacobZheng0927/spark
that referenced
this pull request
May 11, 2024
…=` instead of `sameElements` for Arrays ### What changes were proposed in this pull request? Improve test output for the actual query to be printed alongside of expected ### Why are the changes needed? To reduce confusion later ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-47939` `testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-37965` `testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-27442` ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46318 from vladimirg-db/vladimirg-db/improve-test-output-for-sql-query-suite. Authored-by: Vladimir Golubev <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve test output for the actual query to be printed alongside of expected
Why are the changes needed?
To reduce confusion later
Does this PR introduce any user-facing change?
No
How was this patch tested?
testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-47939testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-37965testOnly org.apache.spark.sql.SQLQuerySuite -- -z SPARK-27442Was this patch authored or co-authored using generative AI tooling?
No