[SPARK-48038][K8S] Promote driverServiceName to KubernetesDriverConf #46276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @pan3793 .
Merged to master.
dongjoon-hyun
added a commit
that referenced
this pull request
Apr 29, 2024
…eStep` ### What changes were proposed in this pull request? This PR aims to remove `clock` parameter from `DriverServiceFeatureStep`. ### Why are the changes needed? Since SPARK-48038, this is not used. - #46276 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #46284 from dongjoon-hyun/SPARK-48046. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Promote
driverServiceNamefromDriverServiceFeatureSteptoKubernetesDriverConf.Why are the changes needed?
To allow other feature steps, e.g. ingress(proposed in SPARK-47954), to access
driverServiceName.Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT has been updated.
Was this patch authored or co-authored using generative AI tooling?
No