Skip to content

[SPARK-47938][SQL] MsSQLServer: Cannot find data type BYTE error #46164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-47938][SQL] MsSQLServer: Cannot find data type BYTE error #46164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
626874f
[SPARK-47938][SQL] MsSQLServer: Cannot find data type BYTE error
yaooqinn Apr 22, 2024
cfe29b9
Remove empty line
dongjoon-hyun Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...egration-tests/src/test/scala/org/apache/spark/sql/jdbc/MsSqlServerIntegrationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,4 +437,12 @@ class MsSqlServerIntegrationSuite extends DockerJDBCIntegrationSuite {
.load()
assert(df.collect().toSet === expectedResult)
}

test("SPARK-47938: Fix 'Cannot find data type BYTE' in SQL Server") {
spark.sql("select cast(1 as byte) as c0")
.write
.jdbc(jdbcUrl, "test_byte", new Properties)
val df = spark.read.jdbc(jdbcUrl, "test_byte", new Properties)
checkAnswer(df, Row(1.toShort))
}
}
1 change: 1 addition & 0 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ private case class MsSqlServerDialect() extends JdbcDialect {
case BinaryType => Some(JdbcType("VARBINARY(MAX)", java.sql.Types.VARBINARY))
case ShortType if !SQLConf.get.legacyMsSqlServerNumericMappingEnabled =>
Some(JdbcType("SMALLINT", java.sql.Types.SMALLINT))
case ByteType => Some(JdbcType("SMALLINT", java.sql.Types.TINYINT))
case _ => None
}

Expand Down