[SPARK-47457][SQL] Backport a6bffcc3e5f0a190b5b7f5c30808b604acc30607 #45645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt` to handle Hadoop 3.4+ ### What changes were proposed in this pull request? This PR aims to fix `IsolatedClientLoader.supportsHadoopShadedClient` to handle Hadoop 3.4+ correctly. ### Why are the changes needed? Apache Spark 3.4+ support shaded clients, but currently `supportsHadoopShadedClient` returns `false`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45585 from dongjoon-hyun/SPARK-47457. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
requested changes
Mar 21, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Hi, @tobiasstadler .
Sorry but it's an improvement for Apache Spark 4.0.0. As the author of that commit, I want to keep all Hadoop 3.4 activity in Apache Spark 4 only.
Member
|
Let me close this PR first to prevent accidental merging. We can continue our discussion on this topic. |
Member
|
For the record, Apache Spark community is actively testing Apache Hadoop 3.4, but it's too early to say that it can survive until Apache Spark 4.0.0 release. It's only our aspiration to have Apache Hadoop 3.4 in Apache Spark 4.0.0. Please see our downgrade history. This can happen for Apache Hadoop 3.4.0 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport a6bffcc to 3.5
Why are the changes needed?
Apache Spark 3.4+ support shaded clients, but currently
supportsHadoopShadedClientreturnsfalse.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI
Was this patch authored or co-authored using generative AI tooling?
No.