[SPARK-47327][SQL] Move sort keys concurrency test to CollationFactorySuite #45501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
reviewed
Mar 15, 2024
MaxGekk
reviewed
Mar 15, 2024
|
|
||
| test("test concurrently generating collation keys") { | ||
| // generating ICU sort keys is not thread-safe by default so this should fail | ||
| // if we don't handle the concurrency properly on Collator level |
Member
There was a problem hiding this comment.
Just in case, could you point out where do we handle this?
Contributor
Author
There was a problem hiding this comment.
right now we just do it by freezing the collator as described in #45436, but we would probably have to reexamine this as current solution is not very performant
MaxGekk
approved these changes
Mar 16, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
The test failure Run / Build modules: yarn, connect is not related to the changes, I believe.
+1, LGTM. Merging to master.
Thank you, @stefankandic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Move concurrency test to the
CollationFactorySuiteWhy are the changes needed?
This is more appropriate location for the test as it directly uses the
CollationFactory.Also, I just found out that
parmethod is highly discouraged and that we should useParSeqinstead.Does this PR introduce any user-facing change?
No
How was this patch tested?
With existing UTs
Was this patch authored or co-authored using generative AI tooling?
No