[SPARK-46043][SQL][FOLLOWUP] do not resolve v2 table provider with custom session catalog #45440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I'm still confused about why we need to separate this function from loadTable. How could a custom session catalog table fail to be resolved?
Contributor
Author
There was a problem hiding this comment.
a custom v2 session catalog can extend DelegatingCatalogExtension and take the Table returned by V2SessionCatalog.loadTable then return something else. That said, we should keep V2SessionCatalog.loadTable to return V1Table and resolve data source v2 table provider afterwards, which is after calling CatalogV2Utils.loadTable
cloud-fan
changed the title
allisonwang-db
approved these changes
Mar 12, 2024
yaooqinn
approved these changes
Mar 12, 2024
Member
|
Merged to master Thank you @cloud-fan @allisonwang-db |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up of #43949 to fix a breaking change. Spark allows people to provide a custom session catalog, which may return custom v2 tables based on the table provider. #43949 resolves the table provider earlier than the custom session catalog, and may break custom session catalogs. This PR fixes it by not resolving table provider if custom session catalog is present.
Why are the changes needed?
avoid breaking custom session catalogs
Does this PR introduce any user-facing change?
no, #43949 is not released yet.
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no