[SPARK-3688][SQL]LogicalPlan can't resolve column correctlly #4524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
|
Test build #27278 has started for PR 4524 at commit
|
|
Test build #27278 has finished for PR 4524 at commit
|
|
Test PASSed. |
Contributor
There was a problem hiding this comment.
If we are going to merge this, can you add javadoc for these two methods to explain what they do, and what the differences are?
Contributor
There was a problem hiding this comment.
Also they should be private or at least protected.
Contributor
|
I merged this since we're close to the deadline. Thanks! Please address @rxin comments in a follow up. |
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2015
This PR fixed the resolving problem described in https://issues.apache.org/jira/browse/SPARK-3688 ``` CREATE TABLE t1(x INT); CREATE TABLE t2(a STRUCT<x: INT>, k INT); SELECT a.x FROM t1 a JOIN t2 b ON a.x = b.k; ``` Author: tianyi <[email protected]> Closes #4524 from tianyi/SPARK-3688 and squashes the following commits: 237a256 [tianyi] resolve a name with table.column pattern first. (cherry picked from commit 44b2311) Signed-off-by: Michael Armbrust <[email protected]>
rxin
added a commit
to rxin/spark
that referenced
this pull request
Feb 11, 2015
As a follow-up to apache#4524
Contributor
|
FYI I added more inline comment #4539 |
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2015
As a follow-up to #4524 Author: Reynold Xin <[email protected]> Closes #4539 from rxin/SPARK-3688 and squashes the following commits: 5ac56c7 [Reynold Xin] exists da8eea4 [Reynold Xin] [SPARK-3688][SQL] More inline comments for LogicalPlan. (cherry picked from commit fa6bdc6) Signed-off-by: Reynold Xin <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Feb 11, 2015
As a follow-up to #4524 Author: Reynold Xin <[email protected]> Closes #4539 from rxin/SPARK-3688 and squashes the following commits: 5ac56c7 [Reynold Xin] exists da8eea4 [Reynold Xin] [SPARK-3688][SQL] More inline comments for LogicalPlan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the resolving problem described in https://issues.apache.org/jira/browse/SPARK-3688