Skip to content

[SPARK-47119][BUILD] Add hive-jackson-provided profile #45201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-47119][BUILD] Add hive-jackson-provided profile #45201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions assembly/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,13 @@
<id>hive-provided</id>
<properties>
<hive.deps.scope>provided</hive.deps.scope>
<hive.jackson.scope>provided</hive.jackson.scope>
Copy link
Member

@viirya viirya Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, both in hive-provided and hive-jackson-provided profiles, the config value is provided. What's the difference between them?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, these dependencies follow hive.deps.scope like the following. So, we need to preserve the existing behavior.

- <scope>${hive.deps.scope}</scope>
+ <scope>${hive.jackson.scope}</scope>

Copy link
Member

@viirya viirya Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, hive-jackson-provided has hive in compile scope and only jackson in provided scope.

Copy link
Member

@viirya viirya Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name hive-jackson-provided makes me think both are provided.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

</properties>
</profile>
<profile>
<id>hive-jackson-provided</id>
<properties>
<hive.jackson.scope>provided</hive.jackson.scope>
</properties>
</profile>
<profile>
Expand Down
5 changes: 3 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@
<hive.deps.scope>compile</hive.deps.scope>
<hive.storage.version>2.8.1</hive.storage.version>
<hive.storage.scope>compile</hive.storage.scope>
<hive.jackson.scope>compile</hive.jackson.scope>
<hive.common.scope>compile</hive.common.scope>
<hive.llap.scope>compile</hive.llap.scope>
<hive.serde.scope>compile</hive.serde.scope>
Expand Down Expand Up @@ -1878,13 +1879,13 @@
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-core-asl</artifactId>
<version>${codehaus.jackson.version}</version>
<scope>${hive.deps.scope}</scope>
<scope>${hive.jackson.scope}</scope>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
<version>${codehaus.jackson.version}</version>
<scope>${hive.deps.scope}</scope>
<scope>${hive.jackson.scope}</scope>
</dependency>
<dependency>
<groupId>${hive.group}</groupId>
Expand Down