-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-5454] More robust handling of self joins #4520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #27270 has started for PR 4520 at commit
|
|
Test build #27270 has finished for PR 4520 at commit
|
|
Test FAILed. |
|
Test build #27271 has started for PR 4520 at commit
|
|
Test build #27271 has finished for PR 4520 at commit
|
|
Test FAILed. |
|
Test build #27276 has started for PR 4520 at commit
|
|
Test build #27276 has finished for PR 4520 at commit
|
|
Test PASSed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
space before =>
|
LGTM in general except some of the minor issues. My original thought on this, is adding a new Anyway, let's leave it for the future improvement. |
|
Test build #27296 has started for PR 4520 at commit
|
|
Test build #27296 has finished for PR 4520 at commit
|
|
Test PASSed. |
Also I fix a bunch of bad output in test cases. Author: Michael Armbrust <[email protected]> Closes #4520 from marmbrus/selfJoin and squashes the following commits: 4f4a85c [Michael Armbrust] comments 49c8e26 [Michael Armbrust] fix tests 6fc38de [Michael Armbrust] fix style 55d64b3 [Michael Armbrust] fix dataframe selfjoins (cherry picked from commit a60d2b7) Signed-off-by: Michael Armbrust <[email protected]>
Also I fix a bunch of bad output in test cases.