Skip to content

Conversation

@marmbrus
Copy link
Contributor

Also I fix a bunch of bad output in test cases.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27270 has started for PR 4520 at commit 55d64b3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27270 has finished for PR 4520 at commit 55d64b3.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27270/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27271 has started for PR 4520 at commit 6fc38de.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27271 has finished for PR 4520 at commit 6fc38de.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27271/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27276 has started for PR 4520 at commit 49c8e26.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27276 has finished for PR 4520 at commit 49c8e26.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27276/
Test PASSed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space before =>

@chenghao-intel
Copy link
Contributor

LGTM in general except some of the minor issues.

My original thought on this, is adding a new Project on top of the MultiInstanceRelation(if it appears more than once in the query tree), so we can still keep the same reference to the original MultiInstanceRelation instance, and this probably give us an opportunity to optimize the query by only computing the MultiInstanceRelation once.

Anyway, let's leave it for the future improvement.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27296 has started for PR 4520 at commit 4f4a85c.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 11, 2015

Test build #27296 has finished for PR 4520 at commit 4f4a85c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27296/
Test PASSed.

asfgit pushed a commit that referenced this pull request Feb 11, 2015
Also I fix a bunch of bad output in test cases.

Author: Michael Armbrust <[email protected]>

Closes #4520 from marmbrus/selfJoin and squashes the following commits:

4f4a85c [Michael Armbrust] comments
49c8e26 [Michael Armbrust] fix tests
6fc38de [Michael Armbrust] fix style
55d64b3 [Michael Armbrust] fix dataframe selfjoins

(cherry picked from commit a60d2b7)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in a60d2b7 Feb 11, 2015
@marmbrus marmbrus deleted the selfJoin branch February 17, 2015 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants