Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR adds license header to docs/_plugins files.

Why are the changes needed?

To comply Apache License 2.0

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

Existing CI should verify it e.g., linter.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Jan 10, 2024
@HyukjinKwon HyukjinKwon changed the title [MINOR] Add license header at docs/_plugins [MINOR][DOCS] Add license header at docs/_plugins Jan 10, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon HyukjinKwon deleted the minor-license branch January 15, 2024 00:46
@nchammas
Copy link
Contributor

Should we update the RAT excludes?

I believe this is why the build did not catch these missing licenses.

@HyukjinKwon
Copy link
Member Author

I think we should probably update.

@nchammas
Copy link
Contributor

FYI - I am checking upstream with the RAT devs to see if we can improve how the tool works. Having RAT scan docs/ triggers a lot of spurious failures that are tedious to sort out.

Because we use the CLI and not the Maven plugin (some history here), RAT does not automatically look at our .gitignore files. And the RAT exclude file patterns are regular expressions and not wildcard expressions, which I find confusing. (I think I am not alone on this point, judging from some of the lines in .rat-excludes.)

I am following RAT-323 and RAT-352 to see if RAT will get some usability improvements for the CLI in the near future.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants