-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-40876][SQL][TESTS][FOLLOWUP] Fix failed test in ParquetTypeWideningSuite when SPARK_ANSI_SQL_MODE is set to true
#44481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ParquetTypeWideningSuite that violate the data type conversion rules under ANSI modeParquetTypeWideningSuite that violate the data type conversion rules under ANSI mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that only the test cases used the input test data that would fail to type conversion when ANSI MODE is set to true when constructing test cases that would throw errors when read. In this PR, To quickly fix , I have skipped these three test inputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we just use valid int values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d95098c change to use 1 and 10 as input
8dcc734 to
d95098c
Compare
ParquetTypeWideningSuite that violate the data type conversion rules under ANSI modeParquetTypeWideningSuite when SPARK_ANSI_SQL_MODE is set to true
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @LuciferYang and @cloud-fan .
Merged to master.
|
Thanks @dongjoon-hyun and @cloud-fan ~ |
What changes were proposed in this pull request?
This pr aims to change the test inputs in
ParquetTypeWideningSuiteto valid int to fix failed test inParquetTypeWideningSuitewhen SPARK_ANSI_SQL_MODE` is set to trueWhy are the changes needed?
Fix the day test failure when
SPARK_ANSI_SQL_MODEis set to true.Does this PR introduce any user-facing change?
No
How was this patch tested?
Before
After
Was this patch authored or co-authored using generative AI tooling?
No