[SPARK-46464][DOC] Fix the scroll issue of tables when overflow #44423
Conversation
|
cc @dongjoon-hyun. IIRC, you had submitted a pull request in the past to truncate Spark configuration keys on the Kubernetes documentation. Did we encounter the same issue? |
docs/building-spark.md
Outdated
|
|
||
| ### Related environment variables | ||
|
|
||
| <div class="table-wrapper"> |
There was a problem hiding this comment.
I'm not a CSS expert, but instead of adding a new div all over the place, couldn't we just add the appropriate styling in the main CSS file directly to all table elements?
docs/css/custom.css
Outdated
| width: 100%; | ||
| overflow-wrap: normal; | ||
| border-collapse: collapse; /* Ensures that the borders collapse into a single border */ | ||
| word-break: normal; |
There was a problem hiding this comment.
If you add overflow-x: auto; here, does it solve the problem without needing all the new divs?
There was a problem hiding this comment.
This makes sense to me, let me add it to somewhere else
| @@ -1,7 +0,0 @@ | |||
| /*! | |||
There was a problem hiding this comment.
Why delete these bootstrap files btw?
docs/css/custom.css
Outdated
| table th, table td { | ||
| border: 1px solid #cccccc; /* Adds a border to each table header and data cell */ | ||
| padding: 6px 13px; /* Optional: Adds padding inside each cell for better readability */ | ||
| max-width: 895px; /* Adjusted to `max-width(914px) of .content - padding` to avoid hidden content from a single cell */ |
There was a problem hiding this comment.
Hmm, so without this some table cells hide their content?
Yes, this is a mailing list reported issue. However, as you see in the mailing list, I didn't try to fix the scrollbar issue because it's a global issue instead of this specific table. I fixed only a specific table layout. |
@dongjoon-hyun, thanks for providing this information. So, changing the |
### What changes were proposed in this pull request? https://spark.apache.org/docs/3.4.1/running-on-kubernetes.html#spark-properties https://spark.apache.org/docs/latest/running-on-kubernetes.html#spark-properties As listed above, the doc content in 3.5.0 cannot scroll horizontally. Users can only see the rest of its content when a table overflows if they zoom out as much as possible, resulting in hard-to-read minor characters. This PR changes the HTML body overflow-x from hidden to auto to enable the underlying table to scroll horizontally. ### Why are the changes needed? Fix documentation ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? #### Before  #### After  ### Was this patch authored or co-authored using generative AI tooling? no Closes #44423 from yaooqinn/SPARK-46464. Authored-by: Kent Yao <[email protected]> Signed-off-by: Kent Yao <[email protected]> (cherry picked from commit fc7d7bc) Signed-off-by: Kent Yao <[email protected]>
|
Thank you all, merged to master and 3.5 |
4 participants
What changes were proposed in this pull request?
https://spark.apache.org/docs/3.4.1/running-on-kubernetes.html#spark-properties
https://spark.apache.org/docs/latest/running-on-kubernetes.html#spark-properties
As listed above, the doc content in 3.5.0 cannot scroll horizontally. Users can only see the rest of its content when a table overflows if they zoom out as much as possible, resulting in hard-to-read minor characters.
This PR changes the HTML body overflow-x from hidden to auto to enable the underlying table to scroll horizontally.
Why are the changes needed?
Fix documentation
Does this PR introduce any user-facing change?
no
How was this patch tested?
Before
After
Was this patch authored or co-authored using generative AI tooling?
no