[SPARK-46313][CORE] Log Spark HA recovery duration
#44243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Spark HA recovery duration
yaooqinn
reviewed
Dec 8, 2023
| schedule() | ||
| logInfo("Recovery complete - resuming operations!") | ||
| val timeTakenNs = System.nanoTime() - recoveryStartTimeNs | ||
| logInfo(s"Recovery complete in ${timeTakenNs / 1000000000d}s - resuming operations!") |
Member
There was a problem hiding this comment.
0.043445167s may be less readable for humans. How about rounding to milliseconds？
TimeUnit.NANOSECONDS.toMillis(timeTakenNs) ms or TimeUnit.NANOSECONDS.toMillis(timeTakenNs) / 1000.0 s
Member
Author
|
To @yaooqinn , I addressed your comments and updated the PR description example. |
yaooqinn
approved these changes
Dec 8, 2023
Member
yaooqinn
left a comment
yaooqinn
left a comment
There was a problem hiding this comment.
LGTM, thank you @dongjoon-hyun
Member
Author
|
Thank you, @yaooqinn ! Merged to master. |
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
### What changes were proposed in this pull request? This PR aims to log `Spark HA` recovery duration. ### Why are the changes needed? It will show the elapsed time like the following. ``` - 23/12/07 18:25:29 INFO Master: Recovery complete - resuming operations! - 23/12/07 18:25:29 INFO Master: Recovery complete in 60.020s - resuming operations! ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44243 from dongjoon-hyun/SPARK-46313. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
### What changes were proposed in this pull request? This PR aims to log `Spark HA` recovery duration. ### Why are the changes needed? It will show the elapsed time like the following. ``` - 23/12/07 18:25:29 INFO Master: Recovery complete - resuming operations! - 23/12/07 18:25:29 INFO Master: Recovery complete in 60.020s - resuming operations! ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs and manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44243 from dongjoon-hyun/SPARK-46313. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to log
Spark HArecovery duration.Why are the changes needed?
It will show the elapsed time like the following.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs and manual review.
Was this patch authored or co-authored using generative AI tooling?
No.