Skip to content

[SPARK-5628] Add version option to spark-ec2 #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-5628] Add version option to spark-ec2 #4414

wants to merge 1 commit into from

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Feb 6, 2015

Every proper command line tool should include a --version option or something similar.

This PR adds this to spark-ec2 using the standard functionality provided by optparse.

One thing we don't do here is follow the Python convention of setting __version__, since it seems awkward given how spark-ec2 is laid out.

@nchammas nchammas force-pushed the spark-ec2-show-version branch from 31ec6f1 to 914cab5 Compare February 6, 2015 02:43
@SparkQA
Copy link

SparkQA commented Feb 6, 2015

Test build #26887 has started for PR 4414 at commit 914cab5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 6, 2015

Test build #26887 has finished for PR 4414 at commit 914cab5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 6, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26887/
Test PASSed.

@nchammas
Copy link
Contributor Author

nchammas commented Feb 6, 2015

cc @shivaram

@JoshRosen
Copy link
Contributor

JoshRosen commented Feb 6, 2015

LGTM. I'm going to pull this into master (1.4.0) and branch-1.3 (1.3.0). I'll also commit it to branch-1.2 (1.2.2), but for that I'll update the version number to match the existing number used in those branches.

asfgit pushed a commit that referenced this pull request Feb 6, 2015
@nchammas @JoshRosen
[SPARK-5628] Add version option to spark-ec2
ab0ffde 
Every proper command line tool should include a `--version` option or something similar.

This PR adds this to `spark-ec2` using the standard functionality provided by `optparse`.

One thing we don't do here is follow the Python convention of setting `__version__`, since it seems awkward given how `spark-ec2` is laid out.

Author: Nicholas Chammas <[email protected]>

Closes #4414 from nchammas/spark-ec2-show-version and squashes the following commits:

914cab5 [Nicholas Chammas] add version info

(cherry picked from commit 70e5b03)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 70e5b03 Feb 6, 2015
@JoshRosen
Copy link
Contributor

JoshRosen commented Feb 6, 2015

Actually, I'm going to hold off on the branch-1.2 (1.2.2) commit for now, since there's a bit of divergence in that branch and I don't want to break anything.

@nchammas
Copy link
Contributor Author

nchammas commented Feb 6, 2015

Thanks for the review @JoshRosen. I'll tag the JIRA issue for backport.

@nchammas nchammas deleted the spark-ec2-show-version branch February 6, 2015 20:31
@nchammas nchammas restored the spark-ec2-show-version branch February 6, 2015 20:32
@nchammas
Copy link
Contributor Author

nchammas commented Feb 6, 2015

Btw, did you mean 1.2.1?

@JoshRosen
Copy link
Contributor

JoshRosen commented Feb 6, 2015

I'm assuming that the 1.2.1 vote will pass, so anything new that goes into branch-1.2 will be part of 1.2.2.

@JoshRosen
Copy link
Contributor

JoshRosen commented Feb 6, 2015

(I actually use a set of TextExpander macros for writing my commit messages, so I only need to type ;b12 to insert branch-1.2 (1.2.2).)

@nchammas
Copy link
Contributor Author

nchammas commented Feb 6, 2015

Oh, nice.

BTW, I don't need to keep this branch around for you to backport into 1.2 right?

@JoshRosen
Copy link
Contributor

JoshRosen commented Feb 6, 2015

Yeah, you shouldn't need to keep the branch around. GitHub should keep the code around in this PR even if you delete the branch at this point.

@nchammas nchammas deleted the spark-ec2-show-version branch February 6, 2015 22:02
@srowen
Copy link
Member

srowen commented Feb 28, 2015

I'm going to backport this to 1.2 and change the version specified here to 1.2.2: PR at #4833

srowen added a commit to srowen/spark that referenced this pull request Feb 28, 2015
@srowen
Backport of apache#4414 to 1.2: Add version option to spark-ec2
e723911
@srowen srowen mentioned this pull request Feb 28, 2015
Closed
asfgit pushed a commit that referenced this pull request Mar 1, 2015
@srowen
SPARK-5628 [EC2] Backport: Add version option to spark-ec2
5226dc7 
Backport of #4414 to 1.2: Add version option to spark-ec2

nchammas JoshRosen : is this about the right backporting of this change?

Author: Sean Owen <[email protected]>

Closes #4833 from srowen/SPARK-5628.2 and squashes the following commits:

e723911 [Sean Owen] Backport of #4414 to 1.2: Add version option to spark-ec2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nchammas @SparkQA @AmplabJenkins @JoshRosen @srowen