-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-5604[MLLIB] remove checkpointDir from LDA #4390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #26834 has started for PR 4390 at commit
|
|
Test build #26834 has finished for PR 4390 at commit
|
|
Test FAILed. |
|
test this please |
|
Test build #26838 has started for PR 4390 at commit
|
|
Test build #26838 has finished for PR 4390 at commit
|
|
Test PASSed. |
|
The changes LGTM One question: Does private[clustering] on "object LDA" not hide stuff in Java docs because it's an object (not a class)? |
|
genjavadoc maps methods to Java public/protect/private. I haven't found a way to hide public methods under a package private companion object yet ... |
`checkpointDir` is a Spark global configuration. Users should set it outside LDA. This PR also hides some methods under `private[clustering] object LDA`, so they don't show up in the generated Java doc (SPARK-5610). jkbradley Author: Xiangrui Meng <[email protected]> Closes #4390 from mengxr/SPARK-5604 and squashes the following commits: a34bb39 [Xiangrui Meng] remove checkpointDir from LDA (cherry picked from commit c19152c) Signed-off-by: Xiangrui Meng <[email protected]>
|
Merged into master and branch-1.3. |
checkpointDiris a Spark global configuration. Users should set it outside LDA. This PR also hides some methods underprivate[clustering] object LDA, so they don't show up in the generated Java doc (SPARK-5610).@jkbradley