Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Feb 5, 2015

checkpointDir is a Spark global configuration. Users should set it outside LDA. This PR also hides some methods under private[clustering] object LDA, so they don't show up in the generated Java doc (SPARK-5610).

@jkbradley

@mengxr mengxr changed the title [SPARK-5604] remove checkpointDir from LDA [SPARK-5604[MLLIB] remove checkpointDir from LDA Feb 5, 2015
@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26834 has started for PR 4390 at commit a34bb39.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26834 has finished for PR 4390 at commit a34bb39.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26834/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Feb 5, 2015

test this please

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26838 has started for PR 4390 at commit a34bb39.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26838 has finished for PR 4390 at commit a34bb39.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26838/
Test PASSed.

@jkbradley
Copy link
Member

The changes LGTM

One question: Does private[clustering] on "object LDA" not hide stuff in Java docs because it's an object (not a class)?

@mengxr
Copy link
Contributor Author

mengxr commented Feb 5, 2015

genjavadoc maps methods to Java public/protect/private. I haven't found a way to hide public methods under a package private companion object yet ...

asfgit pushed a commit that referenced this pull request Feb 5, 2015
`checkpointDir` is a Spark global configuration. Users should set it outside LDA. This PR also hides some methods under `private[clustering] object LDA`, so they don't show up in the generated Java doc (SPARK-5610).

jkbradley

Author: Xiangrui Meng <[email protected]>

Closes #4390 from mengxr/SPARK-5604 and squashes the following commits:

a34bb39 [Xiangrui Meng] remove checkpointDir from LDA

(cherry picked from commit c19152c)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor Author

mengxr commented Feb 5, 2015

Merged into master and branch-1.3.

@asfgit asfgit closed this in c19152c Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants