Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 17, 2023

What changes were proposed in this pull request?

This PR aims to enable Python 3.11 testing in the following daily Python-only Github Action job.

https://github.com/apache/spark/actions/workflows/build_python.yml

Why are the changes needed?

To provide Python 3.11 test coverage to Apache Spark 4.0.0.

Since SPARK-45953 installed Python 3.11 into the infra image, what we need is to add it to the daily job.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

We need to validate this in the daily GitHub Action job.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Nov 17, 2023
@dongjoon-hyun
Copy link
Member Author

cc @HyukjinKwon and @LuciferYang

@zhengruifeng
Copy link
Contributor

@dongjoon-hyun many thanks for working on this!
BTW, do it make sense if we switch to anaconda (or miniconda) for better env management in the future? e.g. easily delete unrelated envs in a job to save disk space.

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @zhengruifeng .

That's a good point although I don't have a preference yet. Let's take a look at that later since it's just a distro transition while keeping the same test coverage.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2!

@dongjoon-hyun
Copy link
Member Author

Today's daily job shows Python 3.11 like the following.

========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
Will test against the following Python executables: ['pypy3', 'python3.10', 'python3.11']

In addition, it exposes a python failure like the following. We will dig more and fix under the umbrella JIRA, SPARK-45981.

Had test failures in pyspark.pandas.tests.computation.test_apply_func with python3.11; see logs.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-45980 branch November 18, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants