[SPARK-45600][PYTHON] Make Python data source registration session level #43742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @HyukjinKwon |
Member
|
Let's hold off for now if this doesn't block sth - I will followup and make some changes for #43630. If we make this session-based, it will give more work to do for SQL support, etc. |
Contributor
Author
|
@HyukjinKwon Sounds good! Thanks for looking into it. |
HyukjinKwon
approved these changes
Nov 16, 2023
allisonwang-db
force-pushed
the
spark-45600-session-level
branch
2 times, most recently
from
0c41406 to
8281347
Compare
allisonwang-db
force-pushed
the
spark-45600-session-level
branch
from
8281347 to
f6ff4cc
Compare
Contributor
Author
|
cc @HyukjinKwon just fixed the merge conflicts! PTAL thanks |
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes dynamic Python data source registration session-scoped. Previously, registered data sources were stored in the
sharedStateand can be referenced by other sessions, which won't work with Spark Connect.Why are the changes needed?
To make Python data source support Spark Connect in the future.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit test
Was this patch authored or co-authored using generative AI tooling?
No