-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-5501][SPARK-5420][SQL] Write support for the data source API #4294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2f91354
Make INSERT OVERWRITE/INTO statements consistent between HiveQL and S…
yhuai cb85b05
Initial write support.
yhuai 7880891
Support CREATE TABLE AS SELECT STATEMENT and the IF NOT EXISTS clause.
yhuai fd6758c
Use BeforeAndAfterAll.
yhuai d37b19c
Cheng's comments.
yhuai 95a7c71
Fix bug when handling IF NOT EXISTS clause in a CREATE TEMPORARY TABL…
yhuai 909924f
Add saveAsTable for the data source API to DataFrame.
yhuai 1a719a5
CREATE TEMPORARY TABLE with IF NOT EXISTS is not allowed for now.
yhuai e5d29f2
Programmatic APIs.
yhuai 9203ec2
Merge remote-tracking branch 'upstream/master' into writeSupport
yhuai 66ebd74
Formatting.
yhuai 0128065
Short hand versions of save and load.
yhuai e789d64
For the Scala API, let users to use tuples to provide options.
yhuai 1682ca6
Better support for CTAS statements.
yhuai 34e1bfb
Address comments.
yhuai 142372a
Merge remote-tracking branch 'upstream/master' into writeSupport
yhuai 1c98881
Fix test.
yhuai 3db1539
save does not take overwrite.
yhuai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -170,6 +170,33 @@ private[sql] trait DataFrameSpecificApi { | |
| @Experimental | ||
| def saveAsTable(tableName: String): Unit | ||
|
|
||
| @Experimental | ||
| def saveAsTable( | ||
| tableName: String, | ||
| dataSourceName: String, | ||
| option: (String, String), | ||
| options: (String, String)*): Unit | ||
|
|
||
| @Experimental | ||
| def saveAsTable( | ||
| tableName: String, | ||
| dataSourceName: String, | ||
| options: java.util.Map[String, String]): Unit | ||
|
|
||
| @Experimental | ||
| def save(path: String): Unit | ||
|
|
||
| @Experimental | ||
| def save( | ||
| dataSourceName: String, | ||
| option: (String, String), | ||
| options: (String, String)*): Unit | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think this one might be ambiguous with the other save. u'd want to declare something like def save(
dataSourceName: String,
overwrite: Boolean,
option: (String, String),
options: (String, String)*): Unit |
||
|
|
||
| @Experimental | ||
| def save( | ||
| dataSourceName: String, | ||
| options: java.util.Map[String, String]): Unit | ||
|
|
||
| @Experimental | ||
| def insertInto(tableName: String, overwrite: Boolean): Unit | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it'd be great to add inline code examples.
we can do this later as separate prs.