Skip to content

[SPARK-5496][MLLIB] Allow both classification and Classification in Algo for trees. #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-5496][MLLIB] Allow both classification and Classification in Algo for trees. #4287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Algo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ object Algo extends Enumeration {
val Classification, Regression = Value

private[mllib] def fromString(name: String): Algo = name match {
case "classification" => Classification
case "regression" => Regression
case "classification" | "Classification" => Classification
case "regression" | "Regression" => Regression
case _ => throw new IllegalArgumentException(s"Did not recognize Algo name: $name")
}
}
5 changes: 5 additions & 0 deletions mllib/src/test/scala/org/apache/spark/mllib/tree/GradientBoostedTreesSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ class GradientBoostedTreesSuite extends FunSuite with MLlibTestSparkContext {
}
}

test("SPARK-5496: BoostingStrategy.defaultParams should recognize Classification") {
for (algo <- Seq("classification", "Classification", "regression", "Regression")) {
BoostingStrategy.defaultParams(algo)
}
}
}

object GradientBoostedTreesSuite {
Expand Down